linux-kernel - Re: [PATCH] power_supply: rt9455_charger: Check if CONFIG_USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150603132054.GA18181@earth>
Date:	Wed, 3 Jun 2015 15:20:55 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Anda-Maria Nicolae <anda-maria.nicolae@...el.com>
Cc:	dbaryshkov@...il.com, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, dwmw2@...radead.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH] power_supply: rt9455_charger: Check if CONFIG_USB_PHY is
 enabled

Hi Anda-Maria,

On Wed, Jun 03, 2015 at 11:47:03AM +0300, Anda-Maria Nicolae wrote:
> If CONFIG_USB_PHY is not enabled, struct notifier_block is not defined and
> compilation fails. Therefore, the functions that process USB event
> notifications are defined only if CONFIG_USB_PHY is enabled.
> There is no need to define these functions if CONFIG_USB_PHY is not
> enabled, since no USB notifications are received in this case.
> Also, since rt9455_set_boost_voltage_before_boost_mode() function is
> called only if USB_EVENT_ID notification is received, this function should
> also be defined only if CONFIG_USB_PHY is enabled.

Thanks, queued for 4.2.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)