linux-kernel - Re: [PATCH] powerpc/eeh: Fix trivial error in eeh_restore_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OF4582BD1A.5370252A-ONCA257E59.001B1345-CA257E59.001B4C24@au1.ibm.com>
Date:	Wed, 3 Jun 2015 14:58:09 +1000
From:	Guo Wen Shan <gwshan@....ibm.com>
To:	David Gibson <david@...son.dropbear.id.au>
Cc:	benh@...nel.crashing.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, mpe@...erman.id.au,
	paulus@...ba.org, gwshan@...ux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/eeh: Fix trivial error in eeh_restore_dev_state()



David Gibson <david@...son.dropbear.id.au> wrote on 03/06/2015 14:52:59:

> From: David Gibson <david@...son.dropbear.id.au>
> To: Guo Wen Shan/Australia/IBM@...AU, mpe@...erman.id.au
> Cc: benh@...nel.crashing.org, paulus@...ba.org, linuxppc-
> dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, David Gibson
> <david@...son.dropbear.id.au>
> Date: 03/06/2015 14:53
> Subject: [PATCH] powerpc/eeh: Fix trivial error in eeh_restore_dev_state
()
>
> Commit 28158cd "powerpc/eeh: Enhance pcibios_set_pcie_reset_state()"
> introduced a fix for a problem where certain configurations could lead to
> pci_reset_function() destroying the state of PCI devices other than the
one
> specified.
>
> Unfortunately, the fix has a trivial bug - it calls pci_save_state()
again,
> when it should be calling pci_restore_state().  This corrects the
problem.
>
> Cc: Gavin Shan <gwshan@....ibm.com>
> Signed-off-by: David Gibson <david@...son.dropbear.id.au>

Acked-by: Gavin Shan <gwshan@...ux.vnet.ibm.com>

Thanks,
Gavin

> ---
>  arch/powerpc/kernel/eeh.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
> index 9ee61d1..ece4181 100644
> --- a/arch/powerpc/kernel/eeh.c
> +++ b/arch/powerpc/kernel/eeh.c
> @@ -719,7 +719,7 @@ static void *eeh_restore_dev_state(void *data,
> void *userdata)
>
>     /* The caller should restore state for the specified device */
>     if (pdev != dev)
> -      pci_save_state(pdev);
> +      pci_restore_state(pdev);
>
>     return NULL;
>  }
> --
> 2.4.2
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/