linux-kernel - Re: [PATCH] crypto: prevent nx 842 load if no hw driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150603050810.GB3884@gondor.apana.org.au>
Date:	Wed, 3 Jun 2015 13:08:10 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Dan Streetman <ddstreet@...e.org>
Cc:	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] crypto: prevent nx 842 load if no hw driver

On Thu, May 28, 2015 at 04:21:31PM -0400, Dan Streetman wrote:
> Change the nx-842 common driver to wait for loading of both platform
> drivers, and fail loading if the platform driver pointer is not set.
> Add an independent platform driver pointer, that the platform drivers
> set if they find they are able to load (i.e. if they find their platform
> devicetree node(s)).
> 
> The problem is currently, the main nx-842 driver will stay loaded even
> if there is no platform driver and thus no possible way it can do any
> compression or decompression.  This allows the crypto 842-nx driver
> to load even if it won't actually work.  For crypto compression users
> (e.g. zswap) that expect an available crypto compression driver to
> actually work, this is bad.  This patch fixes that, so the 842-nx crypto
> compression driver won't load if it doesn't have the driver and hardware
> available to perform the compression.
> 
> Signed-off-by: Dan Streetman <ddstreet@...e.org>

Applied.  Though I had to do the Makefile bit by hand because
it contains references to nx-compress-test which doesn't exist
in my tree.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/