linux-kernel - Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Jun 2015 10:03:36 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
CC:	Andy Lutomirski <luto@...capital.net>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Brian Gerst <brgerst@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code
 in arch/x86/entry/

On 06/03/2015 09:59 AM, Ingo Molnar wrote:
> So the x86 syscall/irq/etc. entry code is scattered in
> over 40 files all over the x86 architecture, making it
> hard to get a good overview of the code and its current
> status.
> 
> Move all the files to arch/x86/entry/.
> 
> This first step is as-is, no file names were changed - but the next
> step will be to organize things in a bit more maintainable fashion.
> 
> If there are no fundamental objections then I'll commit this to
> tip:x86/asm. (I've drained most of the pending patches to these
> files - but porting them should be easy in any case.)

I would prefer if it was made a separate topic.

I like the patch set (and you can add my Acked-by:) *except* 7/7, and
the reason for that is that it really isn't entry code, it is user space
code.

I also dislike deep directory hierarchies in general, unless it really
be avoided, like boot/ or realmode/.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/