linux-kernel - Re: kernel/params.c: 'err' variable "set but not used" and perhaps should be?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150604021935.GN20091@mtj.duckdns.org>
Date:	Thu, 4 Jun 2015 11:19:35 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Louis Langholtz <lou_langholtz@...com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: kernel/params.c: 'err' variable "set but not used" and perhaps
 should be?

On Thu, Jun 04, 2015 at 11:03:16AM +0930, Rusty Russell wrote:
> Please describe the circumstances under which this function can fail.

Allocation failure obviously and violatin of certain API rules -
e.g. dup names, wrong nesting, activation rule violations.  Some can
be warned automatically but I'm not sure about e.g. activation rule
violation.

Also, please note that w/ kmemcg order-0 allocation failures are a lot
more common and we probably won't want to print out warnings
automatically.  For module's use case, it can just trigger warnings
and continue on but I don't think it'd be a good idea to cripple the
API by making it trigger warnings internally and then make it return
void.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/