linux-kernel - Re: kernel/params.c: 'err' variable "set but not used" and perhaps should be?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 05 Jun 2015 05:16:53 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Tejun Heo <htejun@...il.com>
Cc:	Louis Langholtz <lou_langholtz@...com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: kernel/params.c: 'err' variable "set but not used" and perhaps should be?

Tejun Heo <htejun@...il.com> writes:
> On Thu, Jun 04, 2015 at 11:03:16AM +0930, Rusty Russell wrote:
>> Please describe the circumstances under which this function can fail.
>
> Allocation failure obviously

Won't happen here, this is a boot-time function.  version_sysfs_builtin.
The __init is the clue.

> and violatin of certain API rules -
> e.g. dup names, wrong nesting, activation rule violations.

Duplicated names imply some weird build error, and we get an warning in
that case already.

Not sure how we'd get wrong nesting or whatever activation rule
violations are, but happy to be enlightened?

Neither of the others justify version_sysfs_builtin checking the
return value of sysfs_create_file().

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/