| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <87zj4fte9r.fsf@rustcorp.com.au> Date: Fri, 05 Jun 2015 05:52:24 +0930 From: Rusty Russell <rusty@...tcorp.com.au> To: Lucas De Marchi <lucas.de.marchi@...il.com> Cc: Andreas Mohr <andi@...as.de>, Andrew Morton <akpm@...ux-foundation.org>, Bertrand Jacquin <beber@...eeweb.net>, Marco d'Itri <md@...ux.it>, linux-modules <linux-modules@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>, Jon Masters <jcm@...hat.com> Subject: Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing. Lucas De Marchi <lucas.de.marchi@...il.com> writes: >> + gzip and xz (but doesn't by default, at least as of version 18!). > > This is pretty much misleading. There's no such a default option. It's > like saying kernel doesn't support feature X, Y or Z by default > because make defconfig doesn't turn them on. Nobody except Linus expects a defconfig to boot. I expect ./configure to give me a working tool; these *are* defaults, and setting them *is* your responsibility as author. When it became an in-kernel option rather than some weird distro thing, the old default was wrong. ... Though I hadn't realized that Marco had deliberately decided to leave support off. Surprising, since liblzma and libz seem required on Debian anyway. So I'm sorry Andreas: if your maintainer doesn't care about your case, there's not much I can do :( Subject: modules: clarify CONFIG_MODULE_COMPRESS help, suggest 'N'. Andreas turned this option on, only to find out Debian (and Ubuntu!) don't enable support in their kmod builds. Shorten the text, and suggest N at the bottom (at least for now). Reported-by: Andreas Mohr <andim2@...rs.sf.net> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au> diff --git a/init/Kconfig b/init/Kconfig index 968a001790af..bcb7e1e13f7d 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1948,26 +1948,21 @@ config MODULE_COMPRESS bool "Compress modules on installation" depends on MODULES help - This option compresses the kernel modules when 'make - modules_install' is run. - The modules will be compressed either using gzip or xz depend on the - choice made in "Compression algorithm". + Compresses kernel modules when 'make modules_install' is run; gzip or + xz depending on "Compression algorithm" below. - module-init-tools has support for gzip format while kmod handle gzip - and xz compressed modules. + module-init-tools MAY support gzip, and kmod MAY support gzip and xz. - When a kernel module is installed from outside of the main kernel - source and uses the Kbuild system for installing modules then that - kernel module will also be compressed when it is installed. + Out-of-tree kernel modules installed using Kbuild will also be + compressed upon installation. - This option provides little benefit when the modules are to be used inside - an initrd or initramfs, it generally is more efficient to compress the whole - initrd or initramfs instead. + Note: for modules inside an initrd or initramfs, it's more efficient + to compress the whole initrd or initramfs instead. - This is fully compatible with signed modules while the signed module is - compressed. module-init-tools or kmod handles decompression and provide to - other layer the uncompressed but signed payload. + Note: This is fully compatible with signed modules. + + If in doubt, say N. choice prompt "Compression algorithm" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists