linux-kernel - RE: [PATCH] NFSv4: handle nfs4_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <004101d09ed8$fcbe7850$f63b68f0$@mindspring.com>
Date:	Thu, 4 Jun 2015 11:13:17 -0400
From:	"Frank Filz" <ffilzlnx@...dspring.com>
To:	"'Dominique Martinet'" <dominique.martinet@....fr>,
	<linux-nfs@...r.kernel.org>,
	"'Anna Schumaker'" <anna.schumaker@...app.com>,
	"'Trond Myklebust'" <trond.myklebust@...marydata.com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] NFSv4: handle nfs4_get_referral failure

More detail on this,

Basically what is going on is that a migration event has been detected in
nfs4_get_referral, but the migration recovery is not actually initiated.

We tripped over this because Ganesha intends to support referrals, but the
implementation is incomplete (not all FSALs support referrals, and we don't
necessarily change the fsid) and thus Ganesha's returning an NFS4ERR_MOVED
winds up looking like a migration event to the client (of course we don't
support migration either).

Thanks

Frank

> -----Original Message-----
> From: Dominique Martinet [mailto:dominique.martinet@....fr]
> Sent: Thursday, June 4, 2015 11:04 AM
> To: linux-nfs@...r.kernel.org; Anna Schumaker; Trond Myklebust
> Cc: linux-kernel@...r.kernel.org; Dominique Martinet; Frank S. Filz
> Subject: [PATCH] NFSv4: handle nfs4_get_referral failure
> 
> nfs4_proc_lookup_common is supposed to return a posix error, we have to
> handle any error returned that isn't errno
> 
> Reported-by: Olga Kornievskaia <kolga@...app.com>
> Signed-off-by: Frank S. Filz <ffilzlnx@...dspring.com>
> Signed-off-by: Dominique Martinet <dominique.martinet@....fr>
> ---
> 
> Other way of fixing it would be to return something like -EIO directly in
> nfs4_get_referral, but I believe handling exception is the right thing to
do.
> Only other return code atm is -ENOMEM which probably isn't recoverable?
> 
>  fs/nfs/nfs4proc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 627f37c..e7fbf24
> 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -3356,6 +3356,8 @@ static int nfs4_proc_lookup_common(struct
> rpc_clnt **clnt, struct inode *dir,
>  			goto out;
>  		case -NFS4ERR_MOVED:
>  			err = nfs4_get_referral(client, dir, name, fattr,
> fhandle);
> +			if (err == -NFS4ERR_MOVED)
> +				err =
> nfs4_handle_exception(NFS_SERVER(dir), err, &exception);
>  			goto out;
>  		case -NFS4ERR_WRONGSEC:
>  			err = -EPERM;
> --
> 2.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/