[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1433430257-11894-1-git-send-email-dominique.martinet@cea.fr>
Date: Thu, 4 Jun 2015 17:04:17 +0200
From: Dominique Martinet <dominique.martinet@....fr>
To: linux-nfs@...r.kernel.org,
Anna Schumaker <anna.schumaker@...app.com>,
Trond Myklebust <trond.myklebust@...marydata.com>
Cc: linux-kernel@...r.kernel.org,
Dominique Martinet <dominique.martinet@....fr>,
"Frank S. Filz" <ffilzlnx@...dspring.com>
Subject: [PATCH] NFSv4: handle nfs4_get_referral failure
nfs4_proc_lookup_common is supposed to return a posix error, we have to
handle any error returned that isn't errno
Reported-by: Olga Kornievskaia <kolga@...app.com>
Signed-off-by: Frank S. Filz <ffilzlnx@...dspring.com>
Signed-off-by: Dominique Martinet <dominique.martinet@....fr>
---
Other way of fixing it would be to return something like -EIO directly
in nfs4_get_referral, but I believe handling exception is the right
thing to do.
Only other return code atm is -ENOMEM which probably isn't recoverable?
fs/nfs/nfs4proc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 627f37c..e7fbf24 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -3356,6 +3356,8 @@ static int nfs4_proc_lookup_common(struct rpc_clnt **clnt, struct inode *dir,
goto out;
case -NFS4ERR_MOVED:
err = nfs4_get_referral(client, dir, name, fattr, fhandle);
+ if (err == -NFS4ERR_MOVED)
+ err = nfs4_handle_exception(NFS_SERVER(dir), err, &exception);
goto out;
case -NFS4ERR_WRONGSEC:
err = -EPERM;
--
2.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists