linux-kernel - Re: [PATCH v3 7/8] staging:lustre: style cleanups for LNet headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150605090433.GO28762@mwanda>
Date:	Fri, 5 Jun 2015 12:04:33 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	James Simmons <jsimmons@...radead.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	lustre-devel@...ts.lustre.org
Subject: Re: [PATCH v3 7/8] staging:lustre: style cleanups for LNet headers

I'm fine with merging this patch as is.

On Wed, Jun 03, 2015 at 04:43:26PM -0400, James Simmons wrote:
> +	struct lnet_peer	*msg_txpeer;	 /* peer I'm sending to */
> +	struct lnet_peer	*msg_rxpeer;	 /* peer I received from */
> +
> +	void			*msg_private;
> +	struct lnet_libmd	*msg_md;
> +
> +	unsigned int		msg_len;
> +	unsigned int		msg_wanted;
> +	unsigned int		msg_offset;
> +	unsigned int		msg_niov;
> +	struct kvec		*msg_iov;
> +	lnet_kiov_t		*msg_kiov;
> +
> +	lnet_event_t		msg_ev;
> +	lnet_hdr_t		msg_hdr;

These aren't in "lustre style".  Lustre style is more like:

	unsigned int		msg_len;
	unsigned int		msg_wanted;
	unsigned int		msg_offset;
	unsigned int		msg_niov;
	struct kvec	       *msg_iov;
	lnet_kiov_t	       *msg_kiov;


We're going through and re-indenting things.  I think just one space
between type and name is the right thing for .c files but you guys
really should figure out what style you're using for your header files.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/