linux-kernel - Re: [PATCH] SDHCI: Change AMD SDHCI quirk application scope

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150605135230.GJ3679@pd.tnic>
Date:	Fri, 5 Jun 2015 15:52:30 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Wan ZongShun <mcuos.com@...il.com>
Cc:	Wan ZongShun <Vincent.Wan@....com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Wan ZongShun <linux@...os.com>
Subject: Re: [PATCH] SDHCI: Change AMD SDHCI quirk application scope

On Fri, Jun 05, 2015 at 06:01:56PM +0800, Wan ZongShun wrote:
> The KERNCZ is new AMD SB/FCH generation name, like HUDSON2 is old FCH
> generation.
> We will adopt 0x790b as device ID since from this KERNCZ gereration.

True story. Strange name that.

> The i2cpiix4.c driver and eMMC driver both will use this device ID
> macro, Do you think I should submit two patches synchronously? like
> patch1: change i2cpiix4 driver to use PCI_DEVICE_ID_AMD_KERNCZ_SMBUS,
> patch2: for eMMC quirk in sdhci-pci.c?
> 
> And then the PCI_DEVICE_ID_AMD_KERNCZ_SMBUS can be go into pci ids.h?

If you have all those patches ready, you could do a first patch adding
the PCI ID to pci_ids.h only.

Then follow with the different driver changes, i.e. sdhci-pci.c,
i2cpiix4, and so on and make it clear in the 0/n message that they all
depend on the first one.

Or something along those lines.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/