linux-kernel - Re: [PATCH 1/2] debugfs: support read-only and write-only bool types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150605164255.GV14071@sirena.org.uk>
Date:	Fri, 5 Jun 2015 17:42:55 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] debugfs: support read-only and write-only bool types

On Fri, Jun 05, 2015 at 03:34:45PM +0100, Richard Fitzgerald wrote:

> +static ssize_t debugs_read_wo_file(struct file *file, char __user *buf,
> +				   size_t count, loff_t *ppos)
> +{
> +	return -EACCES;
> +}

Perhaps I'm missing something but shouldn't we be able to just omit
empty functions like this (this seems to be what the other ro/wo debugfs
defintions do otherwise these would already be there and it's what I'd
expect)?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)