linux-kernel - lustre: question about lov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 7 Jun 2015 22:11:36 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	HPDD-discuss@...ts.01.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: lustre: question about lov_request.c

Hello,

The function lov_finish_set in 
drivers/staging/lustre/lustre/lov/lov_request.c contains the code:

       if (set->set_pga) {
                int len = set->set_oabufs * sizeof(*set->set_pga);
                OBD_FREE_LARGE(set->set_pga, len);
        }

If I change the call to OBD_FREE_LARGE to kvfree, then len is not useful 
any more.  But actually, at least with grep, I can't find anywhere that 
either the set_pga field or the set_oabufs field is set.  Am I missing 
something, or can the whole if be removed?  Can these two fields go too?

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/