linux-kernel - Re: [RFC PATCH] Rename ia32entry.S to entry_64_compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150607125816.GA6335@gmail.com>
Date:	Sun, 7 Jun 2015 14:58:16 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Brian Gerst <brgerst@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH] Rename ia32entry.S to entry_64_compat_32.S


* Andy Lutomirski <luto@...capital.net> wrote:

> On Fri, Jun 5, 2015 at 2:09 PM, H. Peter Anvin <hpa@...or.com> wrote:
> > Call it sys if it is now only the system call entry points.  Agreed with _64_compat too.
> >
> > Breaking up these snarls of spaghetti assembly will be a blessing.
> 
> I'm not too picky about what we call it or whether we merge it with entry_64.S.  
> *However*, I think the file name should end in _64.S. The whole arch/x86 tree is 
> arranged such that files that end in _64.S or _64.c are build for 64-bit kernels 
> and not for 32-bit kernels.  I see no reason to deviate from that.
> 
> FWIW, I'm eventually planning to completely rewrite the compat entry points to 
> use the new (RFC patches coming in a week or two I hope!) C exit code with 
> opportunistic sysretl at the end.  I'm guessing the result will be about half 
> the size of the current code, and it'll be comprehensible to mere mortals.

Ok, so I think the best is if I leave it alone for now: I've renamed it to 
entry_64_compat.S as per Boris's and hpa's suggestion, but won't merge it into 
entry_64.S (yet), let's see how your C conversion works out!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/