lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 08 Jun 2015 10:31:00 +0200 From: Lukasz Majewski <l.majewski@...sung.com> To: Shailendra Verma <shailendra.capricorn@...il.com> Cc: Viresh Kumar <viresh.kumar@...aro.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Kukjin Kim <kgene@...nel.org>, Krzysztof Kozlowski <k.kozlowski@...sung.com>, linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] cpufreq:exynos-cpufreq - Fix for memory leak in case SOC name does not match. Hi Viresh, > On 25-05-15, 07:39, Shailendra Verma wrote: > > During probe free the memory allocated to "exynos_info" in case of > > unknown SOC type. > > > > Signed-off-by: Shailendra Verma <shailendra.capricorn@...il.com> > > --- > > drivers/cpufreq/exynos-cpufreq.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/cpufreq/exynos-cpufreq.c > > b/drivers/cpufreq/exynos-cpufreq.c index 82d2fbb..8682378 100644 > > --- a/drivers/cpufreq/exynos-cpufreq.c > > +++ b/drivers/cpufreq/exynos-cpufreq.c > > @@ -182,7 +182,7 @@ static int exynos_cpufreq_probe(struct > > platform_device *pdev) ret = exynos5250_cpufreq_init(exynos_info); > > } else { > > pr_err("%s: Unknown SoC type\n", __func__); > > - return -ENODEV; > > + ret = -ENODEV; > > } > > > > if (ret) > > @@ -190,12 +190,14 @@ static int exynos_cpufreq_probe(struct > > platform_device *pdev) > > if (exynos_info->set_freq == NULL) { > > dev_err(&pdev->dev, "No set_freq function > > (ERR)\n"); > > + ret = -EINVAL; > > goto err_vdd_arm; > > } > > > > arm_regulator = regulator_get(NULL, "vdd_arm"); > > if (IS_ERR(arm_regulator)) { > > dev_err(&pdev->dev, "failed to get resource > > vdd_arm\n"); > > + ret = -EINVAL; > > goto err_vdd_arm; > > } > > > > @@ -227,7 +229,7 @@ err_cpufreq_reg: > > regulator_put(arm_regulator); > > err_vdd_arm: > > kfree(exynos_info); > > - return -EINVAL; > > + return ret; > > } > > > > static struct platform_driver exynos_cpufreq_platdrv = { > > Acked-by: Viresh Kumar <viresh.kumar@...aro.org> > Acked-by: Lukasz Majewski <l.majewski@...sung.com> -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists