linux-kernel - Re: [PATCH] debug: Deprecate BUG_ON() use in new code, introduce CRASH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 08 Jun 2015 20:07:00 +0200
From:	Alexander Holler <holler@...oftware.de>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Richard Weinberger <richard.weinberger@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Tejun Heo <htejun@...il.com>,
	Louis Langholtz <lou_langholtz@...com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Trivial patch monkey <trivial@...nel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] debug: Deprecate BUG_ON() use in new code, introduce
 CRASH_ON()

Am 08.06.2015 um 13:27 schrieb Ingo Molnar:
>
> * Alexander Holler <holler@...oftware.de> wrote:
>
>>> I am pretty certain that Greg would have applied such a patch in an eye blink.
>>
>> As you've said it, *probably*. But such a simple exit path as you're proposing
>> doesn't always exist. [...]
>
> As I said it's case by case. I discussed your example (which was a deficient patch
> for multiple reasons) but we'd be wasting everyone's time by discussion
> hypothethical situations.

Sure it was a deficient patch, but still better than what existed for a 
year long in the kernel and which leaded to a reset of a system sometime 
after a wireless remote connected device was turned off. And it showed 
exactly where the problem existed. Maybe I should mention that almost a 
year after I've posted that patch, people still stumbled over the 
problem (and likely had the same hard time to find the reason for a 
sudden reboot without any warning).

I just want to make clear that a brutforce slogan like BUG_ON is bad is 
bad, especially as there are many people which just might repeat that 
slogan without thinking about what they are repeating.

Alexander Holler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/