linux-kernel - Re: [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid of sparse context imbalance warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Jun 2015 12:35:14 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Tolga Ceylan <tolga.ceylan@...il.com>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Arjun AK <arjunak234@...il.com>,
	Greg Donald <gdonald@...il.com>,
	Darshana Padmadas <darshanapadmadas@...il.com>,
	Joe Perches <joe@...ches.com>, HPDD-discuss@...ts.01.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid
 of sparse context imbalance warning

On Wed, Jun 03, 2015 at 01:20:10PM -0700, Tolga Ceylan wrote:
> In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock)
> warning due its inability to detect the noreturn attribute in
> lbug_with_lock() function inside LBUG macro. With this patch, we unlock
> the spinlock before checking the error condition to resolve this warning.

That's a bug in sparse, not in the code, please don't work around tool
bugs by changing kernel code.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/