linux-kernel - Re: [PATCH v4 1/2] watchdog_core: Add watchdog registration deferral mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5575EE6F.3030001@roeck-us.net>
Date:	Mon, 08 Jun 2015 12:35:11 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Jean-Baptiste Theou <jtheou@...neo-embedded.us>,
	Wim Van Sebroeck <wim@...ana.be>
CC:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] watchdog_core: Add watchdog registration deferral
 mechanism

On 06/06/2015 03:25 PM, Jean-Baptiste Theou wrote:
> Currently, watchdog subsystem require the misc subsystem to
> register a watchdog. This may not be the case in case of an
> early registration of a watchdog, which can be required when
> the watchdog cannot be disabled.
>
> This patch introduces a deferral mechanism to remove this requirement.
>
> Signed-off-by: Jean-Baptiste Theou <jtheou@...neo-embedded.us>
> ---
> Changes in v4:
>   - Adjust patch based on Guenter feedbacks on v3
>

You still have lines with > 80 columns, primarily because of very long
variable names. I would suggest to pick shorter names - there is no
technical reason for variables named watchdog_deferred_registration_XXX,
and I don't see why we should have checkpatch warnings just because
of long variable names.

Also, multi-line alignment is still not correct.
I would suggest to run the patch through checkpatch --strict.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/