linux-kernel - Re: [PATCH v4 1/2] watchdog_core: Add watchdog registration deferral mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150608150249.3c6cfcfbe580f61f150359c1@adeneo-embedded.us>
Date:	Mon, 8 Jun 2015 15:02:49 -0700
From:	Jean-Baptiste Theou <jtheou@...neo-embedded.us>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	Wim Van Sebroeck <wim@...ana.be>, <linux-watchdog@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] watchdog_core: Add watchdog registration
 deferral mechanism

Indeed, it make sense.
I will fix this on v5.

Thanks a lot for your valuable feedbacks on this patch.

JB

On Mon, 8 Jun 2015 12:35:11 -0700
Guenter Roeck <linux@...ck-us.net> wrote:

> On 06/06/2015 03:25 PM, Jean-Baptiste Theou wrote:
> > Currently, watchdog subsystem require the misc subsystem to
> > register a watchdog. This may not be the case in case of an
> > early registration of a watchdog, which can be required when
> > the watchdog cannot be disabled.
> >
> > This patch introduces a deferral mechanism to remove this requirement.
> >
> > Signed-off-by: Jean-Baptiste Theou <jtheou@...neo-embedded.us>
> > ---
> > Changes in v4:
> >   - Adjust patch based on Guenter feedbacks on v3
> >
> 
> You still have lines with > 80 columns, primarily because of very long
> variable names. I would suggest to pick shorter names - there is no
> technical reason for variables named watchdog_deferred_registration_XXX,
> and I don't see why we should have checkpatch warnings just because
> of long variable names.
> 
> Also, multi-line alignment is still not correct.
> I would suggest to run the patch through checkpatch --strict.
> 
> Thanks,
> Guenter
> 


-- 
Jean-Baptiste Theou <jtheou@...neo-embedded.us>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/