lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150609085442.4ce53e78@recife.lan>
Date:	Tue, 9 Jun 2015 08:54:42 -0300
From:	Mauro Carvalho Chehab <mchehab@....samsung.com>
To:	lukasz.anaczkowski@...el.com
Cc:	dougthompson@...ssion.com, bp@...en8.de,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tony Luck <tony.luck@...el.com>,
	Aristeu Rozanski <aris@...hat.com>
Subject: Re: [PATCH 0/3] EDAC: add DDR4 flag, misc improvements

Hi Lukasz,

Em Tue,  9 Jun 2015 13:43:09 +0200
lukasz.anaczkowski@...el.com escreveu:

> From: Lukasz Anaczkowski <lukasz.anaczkowski@...el.com>
> 
> Series of patches that makes sb_edac more flexible for adding
> support for future platforms.
> 
> Jim Snow (3):
>   EDAC: add DDR4 flag
>   sb_edac: virtualize several hard-coded functions
>   sb_edac: support for duplicate device IDs
> 
>  drivers/edac/sb_edac.c | 95 ++++++++++++++++++++++++++++++++++++++++----------
>  include/linux/edac.h   |  6 ++--
>  2 files changed, 80 insertions(+), 21 deletions(-)

The patches look interesting, but, specially in the case of patch 3/3,
it is hard to review them without the patches that add support for
future platforms that require multi-bus. I can't, for example,
understand, so far, the need of "allow_dups" function parameter for
sbridge_get_all_devices().

So, I'd like to see this patch series together with the patches
adding support for those new "multi-bus" platforms.

Thanks,
Mauro



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ