[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150609135606.GF32730@opensource.wolfsonmicro.com>
Date: Tue, 9 Jun 2015 14:56:06 +0100
From: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To: Inha Song <ideal.song@...sung.com>
Cc: broonie@...nel.org, lee.jones@...aro.org,
alsa-devel@...a-project.org, patches@...nsource.wolfsonmicro.com,
sameo@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] mfd: wm8994: Fix NULL pointer exception
on missing pdata
On Tue, Jun 09, 2015 at 07:18:32PM +0900, Inha Song wrote:
> If we use the dev_get_platdata, pdata can be NULL in DT environments.
> Actually, NULL pointer exception is occurs with error messages like this:
>
> [ 1.226583] Unable to handle kernel NULL pointer dereference at virtual address 00000044
> [ 1.467910] [<c02f1e38>] (wm8994_irq_init) from [<c02f1bd4>] (wm8994_i2c_probe+0x684/0x858)
> [ 1.476241] [<c02f1bd4>] (wm8994_i2c_probe) from [<c0371c78>] (i2c_device_probe+0x11c/0x17c)
>
> In wm8994-core, we already checked wheter platform data is NULL and set the
> wm8994->pdata to platform data if platform data is not NULL.
> So, we can use wm8994->pdata instead of platform data.
>
> Signed-off-by: Inha Song <ideal.song@...sung.com>
> ---
Acked-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists