linux-kernel - Re: [PATCH v4] Staging: rtl8192e: Casting correct Endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150609135553.GX28762@mwanda>
Date:	Tue, 9 Jun 2015 16:55:53 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@...teon.com>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"mdcasey@...bloom.com" <mdcasey@...bloom.com>,
	"behanw@...verseincode.com" <behanw@...verseincode.com>,
	"mateusz.kulikowski@...il.com" <mateusz.kulikowski@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] Staging: rtl8192e: Casting correct Endianness

On Tue, Jun 09, 2015 at 12:22:27PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> From: Gnanachandran Dhanapal <gdhanapa@...teon.com>
> 
> Casting correct Endianness for __le16 variable used in assignment and
> condition check
> 
> Signed-off-by: Gnanachandran Dhanapal <gdhanapa@...teon.com>
> ---
> v4: Greg review comments addressed

Which ones?

> @@ -2244,8 +2244,9 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb,
>  	struct rtllib_assoc_response_frame *assoc_resp;
>  	struct rtllib_hdr_3addr *header = (struct rtllib_hdr_3addr *) skb->data;
>  
> +	u16 frame_ctl = le16_to_cpu(header->frame_ctl);
>  	netdev_dbg(ieee->dev, "received [RE]ASSOCIATION RESPONSE (%d)\n",
> -		   WLAN_FC_GET_STYPE(header->frame_ctl));
> +		   WLAN_FC_GET_STYPE(frame_ctl));
>  


Blank line in the wrong spot.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/