linux-kernel - Re: [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150609161356.GB27675@opensource.wolfsonmicro.com>
Date:	Tue, 9 Jun 2015 17:13:56 +0100
From:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	lgirdwood@...il.com, patches@...nsource.wolfsonmicro.com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec_remove
	stubs

On Tue, Jun 09, 2015 at 05:00:43PM +0100, Mark Brown wrote:
> On Tue, Jun 09, 2015 at 04:16:56PM +0100, Richard Fitzgerald wrote:
> 
> > +	ret = wm_adsp2_codec_probe(&priv->core.adsp[0], codec);
> > +	if (ret)
> > +		return ret;
> > +
> 
> I'm still not a big fan of the double registration that's being done -
> if nothing else the fact that it's not also factoring out the creation
> of the DSP controls seems wrong.

I don't see the point of trying to fight against the design of ASoC with
the second probe. ASoC gives us what we need at the codec_probe stage
so why try to invent something different?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/