linux-kernel - Re: [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150609162045.GF14071@sirena.org.uk>
Date:	Tue, 9 Jun 2015 17:20:45 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	lgirdwood@...il.com, patches@...nsource.wolfsonmicro.com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec_remove
 stubs

On Tue, Jun 09, 2015 at 05:13:56PM +0100, Richard Fitzgerald wrote:
> On Tue, Jun 09, 2015 at 05:00:43PM +0100, Mark Brown wrote:

> > I'm still not a big fan of the double registration that's being done -
> > if nothing else the fact that it's not also factoring out the creation
> > of the DSP controls seems wrong.

> I don't see the point of trying to fight against the design of ASoC with
> the second probe. ASoC gives us what we need at the codec_probe stage
> so why try to invent something different?

Well, you could've still hung things off the struct device - it's not
like the ASoC level device is a requirement here - and like I say the
fact that it's not actually factoring out the initialisation that's
already happening at the ASoC probe isn't good.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)