linux-kernel - Re: [PATCH 1/2] staging/lustre/llite: remove LL_IOC_REMOVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2015 03:19:10 -0400
From:	Oleg Drokin <green@...uxhacker.ru>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Andreas Dilger <andreas.dilger@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] staging/lustre/llite: remove LL_IOC_REMOVE_ENTRY handler


On Jun 10, 2015, at 3:08 AM, Sudip Mukherjee wrote:

> On Wed, Jun 10, 2015 at 12:41:22AM -0400, green@...uxhacker.ru wrote:
>> From: Oleg Drokin <green@...uxhacker.ru>
>> 
>> It uses getname in unsafe manner and since it's to deal with corrupted
>> or inconsistent filesystem, we are probably better to deal with
>> it from lfsck anyway.
> I am not sure but will it not break the userspace? There may be some
> application who is using this ioctl.

This is an ioctl for a relatively new "distributed namespace" feature.
Our lustre control tool uses it in order to get rid of presumed
incorrect entries that don't point anywhere. But in fact that's pretty
risky and I am of the opinion this is best left to fsck to decide,
it's too easy to create nameless directories otherwise
(and even if we only allow sysadmin to do this, it's still not all that
great of an idea).

> And I think you missed removing the #define LL_IOC_REMOVE_ENTRY from
> lustre_user.h which will not be used anymore. 

Good point.
Thanks.

Bye,
    Oleg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/