linux-kernel - Re: [PATCH 3/4] spi: davinci: change the lower limit of pre-scale divider to 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5577E5CA.80902@ti.com>
Date:	Wed, 10 Jun 2015 03:22:50 -0400
From:	Murali Karicheri <m-karicheri2@...com>
To:	<broonie@...nel.org>, <linux-spi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] spi: davinci: change the lower limit of pre-scale
 divider to 1

On 06/10/2015 03:18 AM, Murali Karicheri wrote:
> SPI hardware spec for Keystone specifies a lower value of 0 for pre-scale
> divider that is used for generating spi clock which translates to a
> clock divider of 2. So fix the lower limit to allow using a higher SPI
> clock.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>
> Acked-by: Sekhar Nori <nsekhar@...com>
> ---
>   drivers/spi/spi-davinci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
> index 5e99106..987afeb 100644
> --- a/drivers/spi/spi-davinci.c
> +++ b/drivers/spi/spi-davinci.c
> @@ -265,7 +265,7 @@ static inline int davinci_spi_get_prescale(struct davinci_spi *dspi,
>
>   	ret = DIV_ROUND_UP(clk_get_rate(dspi->clk), max_speed_hz);
>
> -	if (ret < 3 || ret > 256)
> +	if (ret < 1 || ret > 256)
>   		return -EINVAL;
>
>   	return ret - 1;
>
Please ignore this as I messed up the PATCH prefix. I will re-send it 
with v1 and some updates to the commit log.

-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/