linux-kernel - Re: [PATCH 3/4] mm: Defer flush of writable TLB entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150610081703.GZ26425@suse.de>
Date:	Wed, 10 Jun 2015 09:17:03 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>,
	Hugh Dickins <hughd@...gle.com>,
	Minchan Kim <minchan@...nel.org>,
	Dave Hansen <dave.hansen@...el.com>,
	Andi Kleen <andi@...stfloor.org>,
	H Peter Anvin <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] mm: Defer flush of writable TLB entries

On Wed, Jun 10, 2015 at 09:50:34AM +0200, Ingo Molnar wrote:
> 
> * Mel Gorman <mgorman@...e.de> wrote:
> 
> > +
> > +	/*
> > +	 * If the PTE was dirty then it's best to assume it's writable. The
> > +	 * caller must use try_to_unmap_flush_dirty() or try_to_unmap_flush()
> > +	 * before the page any IO is initiated.
> > +	 */
> 
> Speling nit: "before the page any IO is initiated" does not parse for me.
> 
> > +			/*
> > +			 * Page is dirty. Flush the TLB if a writable entry
> > +			 * potentially exists to avoid CPU writes after IO
> > +			 * starts and then write it out here
> > +			 */
> 
> s/here/here.
> 
> or:
> 
> s/here/here:
> 

Both fixed, thanks.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/