linux-kernel - Re: [PATCH v6 5/6] i2c: at91: print hardware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55782935.30608@cogentembedded.com>
Date:	Wed, 10 Jun 2015 15:10:29 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Cyrille Pitchen <cyrille.pitchen@...el.com>,
	nicolas.ferre@...el.com, linux-i2c@...r.kernel.org,
	wsa@...-dreams.de, mark.rutland@....com,
	devicetree@...r.kernel.org, pawel.moll@....com,
	ijc+devicetree@...lion.org.uk, linux-kernel@...r.kernel.org,
	robh+dt@...nel.org, galak@...eaurora.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 5/6] i2c: at91: print hardware version

Hello.

On 6/10/2015 11:05 AM, Ludovic Desroches wrote:

>>> The probe() function now prints the hardware version of the I2C
>>> controller.

>>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@...el.com>
>>> ---
>>>   drivers/i2c/busses/i2c-at91.c | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)

>>> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
>>> index 817ae69..6e88b30 100644
>>> --- a/drivers/i2c/busses/i2c-at91.c
>>> +++ b/drivers/i2c/busses/i2c-at91.c
>> [...]
>>> @@ -908,7 +910,8 @@ static int at91_twi_probe(struct platform_device *pdev)
>>>   		return rc;
>>>   	}
>>>
>>> -	dev_info(dev->dev, "AT91 i2c bus driver.\n");
>>> +	dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n",

>>     It looks as if you rather print the driver's version. :-)

>  From my point of view, having a version number for a Linux driver would
> be strange

    Not everybody shares your opinion.

> so it's not confusing.

    Oh, it is, from the purely grammatical PoV. Addiung "hardware " to 
"version" (or not mentioning the driver at all) would clear up that confusion.

>>
>>> +		 at91_twi_read(dev, AT91_TWI_VER));
>>>   	return 0;
>>>   }

>> WBR, Sergei

> Regards
> Ludovic

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/