linux-kernel - Re: [RFC][PATCH] printk: Fixup the nmi printk mess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433965193.32331.23.camel@perches.com>
Date:	Wed, 10 Jun 2015 12:39:53 -0700
From:	Joe Perches <joe@...ches.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
	jkosina@...e.cz, paulmck@...ux.vnet.ibm.com, pmladek@...e.cz,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC][PATCH] printk: Fixup the nmi printk mess

On Wed, 2015-06-10 at 21:25 +0200, Peter Zijlstra wrote:
> On Wed, Jun 10, 2015 at 09:19:16AM -0700, Joe Perches wrote:
> > On Wed, 2015-06-10 at 12:02 -0400, Steven Rostedt wrote:
> > 
> > > BTW, the printk.c file is getting rather big.
> > 
> > No joke that.
> 
> $ find kernel/ -type f -name \*.[ch] | while read file; do wc -l $file; done | sort -nr | awk '{ print ++i " " $0 }' | grep "\<printk\.c"
> 13 3245 kernel/printk/printk.c
> 
> so its the 13th biggest file in kernel/, can't really be bothered by that.

printk.c is ~80k of fairly convoluted.
Refactoring would help maintenance.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/