linux-kernel - Re: [PATCH 13/25] perf stat: Move perf_evsel__(alloc|free|reset)_stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150610202153.GC6803@krava.redhat.com>
Date:	Wed, 10 Jun 2015 22:21:53 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andi Kleen <ak@...ux.intel.com>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 13/25] perf stat: Move
 perf_evsel__(alloc|free|reset)_stat_priv into evsel object

On Wed, Jun 10, 2015 at 03:49:25PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jun 10, 2015 at 08:10:46PM +0200, Jiri Olsa escreveu:
> > Moving perf_evsel__(alloc|free|reset)_stat_priv into evsel object,
> > so it could be used outside stat object in following patches.
>  
> > +++ b/tools/perf/util/evsel.c
>   
> > +void perf_evsel__reset_stat_priv(struct perf_evsel *evsel)
> > +{
> > +	int i;
> > +	struct perf_stat *ps = evsel->priv;
> > +
> > +	for (i = 0; i < 3; i++)
> > +		init_stats(&ps->res_stats[i]);
> > +
> > +	perf_stat_evsel_id_init(evsel);
> > +}
> 
> Please move this to some 'stat' specific place, so that evsel.c has
> nothing that is tool specific, like references to 'struct perf_stat'.

ok, util/stat.c then

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/