linux-kernel - Re: [PATCH 08/25] perf stat: Introduce perf_counts_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150610202247.GD6803@krava.redhat.com>
Date:	Wed, 10 Jun 2015 22:22:47 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andi Kleen <ak@...ux.intel.com>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 08/25] perf stat: Introduce
 perf_counts__(alloc|free|reset) functions

On Wed, Jun 10, 2015 at 03:54:27PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jun 10, 2015 at 08:10:41PM +0200, Jiri Olsa escreveu:
> > Move 'struct perf_counts' allocation|free|reset code into
> > separate functions.
> > 
> > Link: http://lkml.kernel.org/n/tip-qu64zmm5zbpbkuybusnkg4gl@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > ---
> >  tools/perf/builtin-stat.c | 19 +++++++------------
> >  tools/perf/util/evsel.c   | 28 +++++++++++++++++++++++-----
> >  tools/perf/util/evsel.h   |  3 +++
> >  3 files changed, 33 insertions(+), 17 deletions(-)
> 
> But please do not move it to 'evsel.[ch]', i.e. you're introducing a new
> class, i.e. "perf_counts", you might as well put them in a separate
> file, i.e. tools/perf/util/counts.[ch].
> 
> And please rename perf_counts__alloc() to perf_counds__new(), ditto for
> __free() -> __delete(), 

ok

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/