linux-kernel - Re: [PATCH v1] ARM: zynq: Fix earlyprintk in big endian mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFdej02+PtnRb_s8mxYu2rgAzihEMWekGyDfVGvkmszjf0x1pw@mail.gmail.com>
Date:	Fri, 12 Jun 2015 12:28:48 +0530
From:	Arun Chandran <achandran@...sta.com>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michal Simek <monstr@...str.eu>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v1] ARM: zynq: Fix earlyprintk in big endian mode

On Thu, Jun 11, 2015 at 11:43 PM, Michal Simek <michal.simek@...inx.com> wrote:
> On 06/10/2015 04:13 PM, Arun Chandran wrote:
>> earlyprintk messages are not appearing on the terminal
>> emulator during a big endian kernel boot. If we
>> byte swap the sending data it comes properly.
>>
>> Signed-off-by: Arun Chandran <achandran@...sta.com>
>> ---
>> ---
>> This can be tested by adding 'early_print("early print test\n");'
>> to setup_arch() in arch/arm/kernel/setup.c
>> ---
>>  arch/arm/include/debug/zynq.S | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/include/debug/zynq.S b/arch/arm/include/debug/zynq.S
>> index bd13ded..0d274fe 100644
>> --- a/arch/arm/include/debug/zynq.S
>> +++ b/arch/arm/include/debug/zynq.S
>> @@ -38,6 +38,7 @@
>>               .endm
>>
>>               .macro  senduart,rd,rx
>> +ARM_BE8(     rev     \rd, \rd )
>>               str     \rd, [\rx, #UART_FIFO_OFFSET]   @ TXDATA
>>               .endm
>>
>>
>
> Tested-by: Michal Simek <michal.simek@...inx.com>
>

I think just using strb instead of str will do the work
much better. I have send v2 with that logic

Thanks for testing it.

--Arun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/