linux-kernel - Re: [PATCH v2] ARM: zynq: Fix earlyprintk in big endian mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <557AA57D.1010104@xilinx.com>
Date:	Fri, 12 Jun 2015 11:25:17 +0200
From:	Michal Simek <michal.simek@...inx.com>
To:	Arun Chandran <achandran@...sta.com>,
	Michal Simek <michal.simek@...inx.com>
CC:	<linux-kernel@...r.kernel.org>, Michal Simek <monstr@...str.eu>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] ARM: zynq: Fix earlyprintk in big endian mode

On 06/12/2015 08:53 AM, Arun Chandran wrote:
> earlyprintk messages are not appearing on the terminal
> emulator during a big endian kernel boot. In BE mode
> sending full words to UART will result in unprintable
> characters as they are byte swapped versions of printable
> ones. So send only bytes.
> 
> Signed-off-by: Arun Chandran <achandran@...sta.com>
> ---
> ---
> Changes since v1:
> 	removed the byte swapping logic. Just send characters instead.
> ---
>  arch/arm/include/debug/zynq.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/debug/zynq.S b/arch/arm/include/debug/zynq.S
> index bd13ded..de86b92 100644
> --- a/arch/arm/include/debug/zynq.S
> +++ b/arch/arm/include/debug/zynq.S
> @@ -38,7 +38,7 @@
>  		.endm
>  
>  		.macro	senduart,rd,rx
> -		str	\rd, [\rx, #UART_FIFO_OFFSET]	@ TXDATA
> +		strb	\rd, [\rx, #UART_FIFO_OFFSET]	@ TXDATA
>  		.endm
>  
>  		.macro	waituart,rd,rx
> 

ok - this works too.

Tested-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/