linux-kernel - Re: [PATCH 04/12] x86/mm/hotplug: Simplify sync_global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150613075102.GD30388@gmail.com>
Date:	Sat, 13 Jun 2015 09:51:02 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-mml@...r.kernel.org,
	Andy Lutomirski <luto@...capital.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Brian Gerst <brgerst@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Waiman Long <Waiman.Long@...com>
Subject: Re: [PATCH 04/12] x86/mm/hotplug: Simplify sync_global_pgds()


* Oleg Nesterov <oleg@...hat.com> wrote:

> Yes I guess I am totally confused ;)
> 
> On 06/11, Ingo Molnar wrote:
> >
> > @@ -178,7 +178,7 @@ void sync_global_pgds(unsigned long start, unsigned long end, int removed)
> >  		 *
> >  		 * So clear the affected entries in every process PGD as well:
> >  		 */
> > -		if (pgd_none(*pgd_ref) && !removed)
> > +		if (pgd_none(*pgd_ref))
> 
> But doesn't this change invalidate the comment above?

Indeed - I fixed the comment to now say:

                /* Only sync (potentially) newly added PGD entries: */
                if (pgd_none(*pgd_ref))
                        continue;

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/