linux-kernel - Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7F15059F-B180-4722-8167-864C4A24CE9B@holtmann.org>
Date:	Mon, 15 Jun 2015 16:43:00 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Ilya Faenson <ifaenson@...adcom.com>
Cc:	Guenter Roeck <linux@...ck-us.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Frederic Danis <frederic.danis@...ux.intel.com>,
	BlueZ development <linux-bluetooth@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

Hi Ilya,

>>> alpha:allmodconfig fails to build in -next with
>>> 
>>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>> 
>>> BOTHER is not defined for all architectures and otherwise only
>>> used with '#ifdef BOTHER'.
>> 
>> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.
>> 
> 
> So far it has been fixed with #ifdef, and this is the first code which
> uses it outside drivers/tty. So my first tendency would be to fix it
> on the user side.
> 
> However, looking into it, I think only alpha and avr32 are affected.
> Let me submit patches against those and see where it goes.
> 
> IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion).

can you extract this and just submit that version. We might just take that into hci_ldisc.c right away.

However fixing the #ifdef around BOTHER is useful as well since they look unneeded. At least I can not see a reason why a platform would not define them.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/