linux-kernel - Re: [PATCH 2/2] apei/erst-dbg: Define pr_fmt macro to avoid the duplication of ERST_DBG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1434379353.2507.52.camel@perches.com>
Date:	Mon, 15 Jun 2015 07:42:33 -0700
From:	Joe Perches <joe@...ches.com>
To:	Wang Long <long.wanglong@...wei.com>
Cc:	rjw@...ysocki.net, lenb@...nel.org, ying.huang@...el.com,
	tony.luck@...el.com, bp@...e.de, gong.chen@...ux.intel.com,
	tomasz.nowicki@...aro.org, lv.zheng@...el.com,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	wanglong@...qinren.net, peifeiyue@...wei.com
Subject: Re: [PATCH 2/2] apei/erst-dbg: Define pr_fmt macro to avoid the
 duplication of ERST_DBG_PFX

On Mon, 2015-06-15 at 09:57 +0000, Wang Long wrote:
> Define pr_fmt macro with {ERST DBG: } prefix, then remove all use
> of ERST_DBG_PFXin the pr_* functions.
[]
> diff --git a/drivers/acpi/apei/erst-dbg.c b/drivers/acpi/apei/erst-dbg.c
[]
> @@ -31,7 +31,8 @@
>  
>  #include "apei-internal.h"
>  
> -#define ERST_DBG_PFX			"ERST DBG: "
> +#undef pr_fmt
> +#define pr_fmt(fmt) "ERST DBG: " fmt

Moving this #define above the first #include is what's
generally done and doesn't require an #undef


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/