linux-kernel - Re: [PATCH 2/2] apei/erst-dbg: Define pr_fmt macro to avoid the duplication of ERST_DBG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5580CDE4.4090300@huawei.com>
Date:	Wed, 17 Jun 2015 09:31:16 +0800
From:	"long.wanglong" <long.wanglong@...wei.com>
To:	Joe Perches <joe@...ches.com>
CC:	<rjw@...ysocki.net>, <lenb@...nel.org>, <ying.huang@...el.com>,
	<tony.luck@...el.com>, <bp@...e.de>, <gong.chen@...ux.intel.com>,
	<tomasz.nowicki@...aro.org>, <lv.zheng@...el.com>,
	<linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<wanglong@...qinren.net>, <peifeiyue@...wei.com>
Subject: Re: [PATCH 2/2] apei/erst-dbg: Define pr_fmt macro to avoid the duplication
 of ERST_DBG_PFX

On 2015/6/15 22:42, Joe Perches wrote:
> On Mon, 2015-06-15 at 09:57 +0000, Wang Long wrote:
>> Define pr_fmt macro with {ERST DBG: } prefix, then remove all use
>> of ERST_DBG_PFXin the pr_* functions.
> []
>> diff --git a/drivers/acpi/apei/erst-dbg.c b/drivers/acpi/apei/erst-dbg.c
> []
>> @@ -31,7 +31,8 @@
>>  
>>  #include "apei-internal.h"
>>  
>> -#define ERST_DBG_PFX			"ERST DBG: "
>> +#undef pr_fmt
>> +#define pr_fmt(fmt) "ERST DBG: " fmt
> 
> Moving this #define above the first #include is what's
> generally done and doesn't require an #undef
> 
OK, Thanks

> 
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/