linux-kernel - Re: [PATCH v15 3/4] soc: rockchip: power-domain: add power domain driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1434380419.2069.38.camel@x220>
Date:	Mon, 15 Jun 2015 17:00:19 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Caesar Wang <wxt@...k-chips.com>
Cc:	heiko@...ech.de, khilman@...aro.org, tomasz.figa@...il.com,
	ulf.hansson@...aro.org, dmitry.torokhov@...il.com,
	dianders@...omium.org, linux-rockchip@...ts.infradead.org,
	"jinkun.hong" <jinkun.hong@...k-chips.com>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Sandeep Nair <sandeep_n@...com>,
	Flora Fu <flora.fu@...iatek.com>,
	Arnd Bergmann <arnd@...db.de>,
	Stephen Warren <swarren@...dia.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Peter De Schrijver <pdeschrijver@...dia.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v15 3/4] soc: rockchip: power-domain: add power domain
 driver

On Sun, 2015-06-14 at 13:13 +0800, Caesar Wang wrote:

> --- /dev/null
> +++ b/drivers/soc/rockchip/Kconfig

> +config PM_GENERIC_DOMAINS
> +        tristate "Rockchip generic power domain"

Since my remarks on v13 you removed the module specific code from 
pm_domains.c. But now this became a tristate symbol. That makes little
sense. Why didn't you keep bool?

> +        depends on PM
> +        help
> +          Say y here to enable power doamin support.

s/doamin/domain/.

> +          In order to meet high performance and low power requirements, a power
> +          management unit is designed or saving power when RK3288 in low power
> +          mode. The RK3288 PMU is dedicated for managing the power ot the whole chip.

s/ot/of/

> +          If unsure, say N.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/