[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 16 Jun 2015 10:00:30 +0800
From: Caesar Wang <wxt@...k-chips.com>
To: Paul Bolle <pebolle@...cali.nl>
CC: heiko@...ech.de, khilman@...aro.org, tomasz.figa@...il.com,
ulf.hansson@...aro.org, dmitry.torokhov@...il.com,
dianders@...omium.org, linux-rockchip@...ts.infradead.org,
"jinkun.hong" <jinkun.hong@...k-chips.com>,
Santosh Shilimkar <santosh.shilimkar@...com>,
Linus Walleij <linus.walleij@...aro.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Sandeep Nair <sandeep_n@...com>,
Flora Fu <flora.fu@...iatek.com>,
Arnd Bergmann <arnd@...db.de>,
Stephen Warren <swarren@...dia.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Peter De Schrijver <pdeschrijver@...dia.com>,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v15 3/4] soc: rockchip: power-domain: add power domain
driver
在 2015年06月15日 23:00, Paul Bolle 写道:
> On Sun, 2015-06-14 at 13:13 +0800, Caesar Wang wrote:
>
>> --- /dev/null
>> +++ b/drivers/soc/rockchip/Kconfig
>> +config PM_GENERIC_DOMAINS
>> + tristate "Rockchip generic power domain"
> Since my remarks on v13 you removed the module specific code from
> pm_domains.c. But now this became a tristate symbol. That makes little
> sense. Why didn't you keep bool?
Yeah, you are right. :s/tristate/bool
I forget it when the driver is moving from 'arch/arm/mach-rockchip/' to
'/driver/soc/rockchip/'.
>
>> + depends on PM
>> + help
>> + Say y here to enable power doamin support.
> s/doamin/domain/.
Done.
>> + In order to meet high performance and low power requirements, a power
>> + management unit is designed or saving power when RK3288 in low power
>> + mode. The RK3288 PMU is dedicated for managing the power ot the whole chip.
> s/ot/of/
Done.
>> + If unsure, say N.
> Thanks,
>
>
> Paul Bolle
Thanks,
Caesar
>
>
>
--
Thanks,
- Caesar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists