linux-kernel - Re: [PATCH] clk: at91: add generated clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55827606.7020908@atmel.com>
Date:	Thu, 18 Jun 2015 09:40:54 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	Josh Wu <josh.wu@...el.com>, <linux-kernel@...r.kernel.org>,
	<mturquette@...libre.com>
Subject: Re: [PATCH] clk: at91: add generated clock driver

Le 18/06/2015 09:33, Boris Brezillon a écrit :
> Hi Paul,
> 
> On Thu, 18 Jun 2015 09:12:36 +0200
> Paul Bolle <pebolle@...cali.nl> wrote:
> 
>> On Wed, 2015-06-17 at 15:23 +0200, Nicolas Ferre wrote:
>>
>>> --- a/arch/arm/mach-at91/Kconfig
>>> +++ b/arch/arm/mach-at91/Kconfig
>>  
>>> +config HAVE_AT91_GENERATED
>>> +	bool
>>
>> This will always be 'n'.  
>>
>>> --- a/drivers/clk/at91/Makefile
>>> +++ b/drivers/clk/at91/Makefile
>>
>>> +obj-$(CONFIG_HAVE_AT91_GENERATED)	+= clk-generated.o
>>
>> And clk-generated.o will never be built.
>>
>> I think your options are to use
>> 	config HAVE_AT91_GENERATED
>> 		def_bool y
>>
>> or
>> 	config HAVE_AT91_GENERATED
>> 		bool "Yadda yadda yadda"
>>
>> or add
>> 	select HAVE_AT91_GENERATED
>>
>> somewhere (possibly even in a second patch). But as it stands the patch
>> looks like an elaborate NOP.
> 
> I guess it will be selected by platforms embedding such clks. We just
> have to wait for those platform to reach mainline ;-). 

Yes, absolutely.

I am in the process, with my colleagues, of building bricks for our
upcoming SoC the sama5d2. So, the basic support for this chip will come
in the next weeks and will select this Kconfig option.

I'd like though that this matter of fact doesn't block this piece of
code from being reviewed or even better merged in order to ease this new
SoC landing...

Bye,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/