linux-kernel - Re: [Patch v2] driver/i2c/mux: Add register based mux i2c-mux-reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5582BB1F.5050606@nokia.com>
Date:	Thu, 18 Jun 2015 14:35:43 +0200
From:	Alexander Sverdlin <alexander.sverdlin@...ia.com>
To:	ext York Sun <yorksun@...escale.com>, wsa@...-dreams.de
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Paul Bolle <pebolle@...cali.nl>,
	Peter Korsgaard <peter.korsgaard@...co.com>
Subject: Re: [Patch v2] driver/i2c/mux: Add register based mux i2c-mux-reg

Hello!

On 17/06/15 23:13, ext York Sun wrote:
> +	switch (mux->data.reg_size) {
> +	case 4:
> +		iowrite32(mux->data.values[chan], mux->data.reg);
> +		break;
> +	case 2:
> +		iowrite16(mux->data.values[chan], mux->data.reg);
> +		break;
> +	case 1:
> +		iowrite8(mux->data.values[chan], mux->data.reg);
> +		break;

I'd like to see at least [optional] read-back operation after each write.
And if you stick with iowrite*(), maybe it desires a comment (in the Documentation/ file?),
that write will be little-Endian, therefore BE users must take care...

Other than that it looks good to me...

-- 
Best regards,
Alexander Sverdlin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/