linux-kernel - Re: [PATCH] staging: rtl8188eu: kill unused hal_data_8188e::fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Jun 2015 18:56:52 +0200
From:	Jakub Sitnicki <jsitnicki@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Larry Finger <Larry.Finger@...inger.net>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: kill unused hal_data_8188e::fw_ractrl flag

On Thu, Jun 18, 2015 at 10:30 AM CEST, Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:
> On Thu, Jun 18, 2015 at 08:31:59AM +0200, Jakub Sitnicki wrote:
>> Flag is never set. Remove it and the code that is dead because of it.
>> 
>> Signed-off-by: Jakub Sitnicki <jsitnicki@...il.com>
>> ---
> <snip>
>> 
>> diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c
>> index 28b5e7b..710fdc3 100644
>> --- a/drivers/staging/rtl8188eu/hal/odm.c
>> +++ b/drivers/staging/rtl8188eu/hal/odm.c
>> @@ -1170,13 +1170,10 @@ void odm_RSSIMonitorCheckCE(struct odm_dm_struct *pDM_Odm)
>>  	}
>>  
>>  	for (i = 0; i < sta_cnt; i++) {
>> -		if (PWDB_rssi[i] != (0)) {
>> -			if (pHalData->fw_ractrl) {
>> -				/*  Report every sta's RSSI to FW */
>> -			} else {
>> -				ODM_RA_SetRSSI_8188E(
>> -				&(pHalData->odmpriv), (PWDB_rssi[i]&0xFF), (u8)((PWDB_rssi[i]>>16) & 0xFF));
>> -			}
>> +		if (PWDB_rssi[i] != 0) {
>> +			ODM_RA_SetRSSI_8188E(&pHalData->odmpriv,
>> +					     PWDB_rssi[i] & 0xFF,
>> +					     (PWDB_rssi[i] >> 16) & 0xFF);
> and you are also removing an extra unneeded () and a typecast.

True.  I could have mentioned that in the commit message as it was
intentional.  Thanks for reviewing it.

Regards,
Jakub

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/