linux-kernel - Re: [PATCH] staging: rtl8188eu: kill unused hal_data_8188e::fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150622144439.GZ28762@mwanda>
Date:	Mon, 22 Jun 2015 17:44:39 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Jakub Sitnicki <jsitnicki@...il.com>, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH] staging: rtl8188eu: kill unused
 hal_data_8188e::fw_ractrl flag

On Thu, Jun 18, 2015 at 02:00:18PM +0530, Sudip Mukherjee wrote:
> On Thu, Jun 18, 2015 at 08:31:59AM +0200, Jakub Sitnicki wrote:
> > --- a/drivers/staging/rtl8188eu/hal/odm.c
> > +++ b/drivers/staging/rtl8188eu/hal/odm.c
> > @@ -1170,13 +1170,10 @@ void odm_RSSIMonitorCheckCE(struct odm_dm_struct *pDM_Odm)
> >  	}
> >  
> >  	for (i = 0; i < sta_cnt; i++) {
> > -		if (PWDB_rssi[i] != (0)) {
> > -			if (pHalData->fw_ractrl) {
> > -				/*  Report every sta's RSSI to FW */
> > -			} else {
> > -				ODM_RA_SetRSSI_8188E(
> > -				&(pHalData->odmpriv), (PWDB_rssi[i]&0xFF), (u8)((PWDB_rssi[i]>>16) & 0xFF));
> > -			}
> > +		if (PWDB_rssi[i] != 0) {
> > +			ODM_RA_SetRSSI_8188E(&pHalData->odmpriv,
> > +					     PWDB_rssi[i] & 0xFF,
> > +					     (PWDB_rssi[i] >> 16) & 0xFF);
> and you are also removing an extra unneeded () and a typecast.

These are minor related changes (on the same line).  It could have been
mentioned in the changelog but if not then it's not really worth
worrying about because it's so small.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/