linux-kernel - Re: [PATCH] staging : Comedi : comedi_fops : Fixed the return error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5587D767.5040004@mev.co.uk>
Date:	Mon, 22 Jun 2015 10:37:43 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Santosh <santhosh.pai88@...oo.com>, hsweeten@...ionengravers.com
CC:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging : Comedi : comedi_fops : Fixed the return error
 code

On 21/06/15 11:01, Santosh wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: ENOSYS means 'invalid syscall nr' and nothing else
>
> Regards,
>
> Santosh Pai
>
>
> 0001-staging-Comedi-comedi_fops-Fixed-the-return-error-co.patch

Greg doesn't usually take patches in attachments.

>  From 502464417255edb52a1db71146e2f33e67df87ce Mon Sep 17 00:00:00 2001
> From: sanpai<santhosh.pai88@...oo.com>
> Date: Sun, 21 Jun 2015 15:05:00 +0530
> Subject: [PATCH] staging : Comedi : comedi_fops : Fixed the return error code
>
>      try_module_get fails when the reference count of the module is not
>      allowed to be incremented ,and hence -EPERM is returned.
>
> Signed-off-by: sanpai<santhosh.pai88@...oo.com>
> ---
>   drivers/staging/comedi/comedi_fops.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 985d94b..d6a37e9 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode, struct file *file)
>   	}
>   	if (dev->attached && dev->use_count == 0) {
>   		if (!try_module_get(dev->driver->module)) {
> -			rc = -ENOSYS;
> +			rc = -EPERM;

Why -EPERM?  I think either -ENODEV or -ENXIO would be better.

>   			goto out;
>   		}
>   		if (dev->open) {
> -- 1.7.9.5
>


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/