linux-kernel - Re: [PATCH 01/08] devicetree: bindings: Remove sh7372 CMT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUTh0bHVgEZ+W31Q2A=37k4k+oGssWAdXSCZ=bt1My71g@mail.gmail.com>
Date:	Mon, 22 Jun 2015 11:38:13 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Simon Horman <horms+renesas@...ge.net.au>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 01/08] devicetree: bindings: Remove sh7372 CMT binding

Hi Magnus,

On Sun, Jun 21, 2015 at 10:09 AM, Magnus Damm <magnus.damm@...il.com> wrote:
> From: Magnus Damm <damm+renesas@...nsource.se>
>
> Remove the sh7372 CMT compat string to reduce maintenance burden.
>
> It should be fine to break DT compatibility because:
> 1) The sh7372 SoC support has been removed from upstream
> 2) The sh7372 CMT DT binding was never part of upstream DTS
> 3) The CMT driver never matches on the sh7372 binding
>
> Signed-off-by: Magnus Damm <damm+renesas@...nsource.se>
> ---
>
>  Documentation/devicetree/bindings/timer/renesas,cmt.txt |    2 --
>  1 file changed, 2 deletions(-)
>
> --- 0001/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> +++ work/Documentation/devicetree/bindings/timer/renesas,cmt.txt        2015-06-20 13:47:59.922366518 +0900
> @@ -32,8 +32,6 @@ Required Properties:
>                 (CMT[234] on sh7372, sh73a0 and r8a7740)
>                 This is a fallback for the above renesas,cmt-32-fast-* entries.
>
> -    - "renesas,cmt-48-sh7372" for the sh7372 48-bit CMT
> -               (CMT1)

You forgot to remove the reference to sh7372 in the "renesas,cmt-48"
fallback section, and the "renesas,cmt-32-sh7372" and
"renesas,cmt-32-fast-sh7372" bindings.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/