linux-kernel - Re: [PATCH] staging: comedi: don't split Author string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5587F525.8010704@mev.co.uk>
Date:	Mon, 22 Jun 2015 12:44:37 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Luis de Bethencourt <luis@...ethencourt.com>,
	linux-kernel@...r.kernel.org
CC:	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: comedi: don't split Author string

On 20/06/15 21:14, Luis de Bethencourt wrote:
> fixes checkpatch.pl WARNING: quoted string split across lines
>
> +MODULE_AUTHOR("David A. Schleef <ds@...leef.org>, "
> +             "Frank Mori Hess <fmhess@...rs.sourceforge.net>");
>
> total: 0 errors, 1 warnings, 114 lines checked
>
> Modules with multiple authors have a MODULE_AUTHOR line for each one.
>
> Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>
> ---
>   drivers/staging/comedi/drivers/das08_cs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/das08_cs.c b/drivers/staging/comedi/drivers/das08_cs.c
> index 93fab68..9c02b17 100644
> --- a/drivers/staging/comedi/drivers/das08_cs.c
> +++ b/drivers/staging/comedi/drivers/das08_cs.c
> @@ -108,7 +108,7 @@ static struct pcmcia_driver das08_cs_driver = {
>   };
>   module_comedi_pcmcia_driver(driver_das08_cs, das08_cs_driver);
>
> -MODULE_AUTHOR("David A. Schleef <ds@...leef.org>, "
> -	      "Frank Mori Hess <fmhess@...rs.sourceforge.net>");
> +MODULE_AUTHOR("David A. Schleef <ds@...leef.org>");
> +MODULE_AUTHOR("Frank Mori Hess <fmhess@...rs.sourceforge.net>");
>   MODULE_DESCRIPTION("Comedi driver for ComputerBoards DAS-08 PCMCIA boards");
>   MODULE_LICENSE("GPL");
>

Okay, it would be nice if the patch subject line mentioned the name of 
the module, but this is the only one in COMEDI with a split author line.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/