linux-kernel - Re: [PATCH 1/3] drm/msm: dsi host: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5588311B.6030806@linaro.org>
Date:	Mon, 22 Jun 2015 17:00:27 +0100
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Archit Taneja <architt@...eaurora.org>,
	dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org
CC:	robdclark@...il.com, hali@...eaurora.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] drm/msm: dsi host: add missing of_node_put()



On 22/06/15 15:54, Archit Taneja wrote:
> Decrement device node refcount if of_get_child_by_name is successfully
> called.
>
> Signed-off-by: Archit Taneja <architt@...eaurora.org>
> ---
>   drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index de04009..1751659 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -1582,6 +1582,8 @@ int msm_dsi_host_register(struct mipi_dsi_host *host, bool check_defer)
>   			node = of_get_child_by_name(msm_host->pdev->dev.of_node,
>   							"panel");
>   			if (node) {
> +				of_node_put(node);
> +

Atleast from the current state of code, It looks like the driver is 
going to refer to the node of_node_put?, So I think this is not the 
right place to have of_node_put.



  >   				if (!of_drm_find_panel(node))
>   					return -EPROBE_DEFER;
>   			}
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/