[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5588E84A.2000509@codeaurora.org>
Date: Tue, 23 Jun 2015 10:32:02 +0530
From: Archit Taneja <architt@...eaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org
CC: robdclark@...il.com, hali@...eaurora.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] drm/msm: dsi host: add missing of_node_put()
On 06/22/2015 09:30 PM, Srinivas Kandagatla wrote:
>
>
> On 22/06/15 15:54, Archit Taneja wrote:
>> Decrement device node refcount if of_get_child_by_name is successfully
>> called.
>>
>> Signed-off-by: Archit Taneja <architt@...eaurora.org>
>> ---
>> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
>> b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> index de04009..1751659 100644
>> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
>> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> @@ -1582,6 +1582,8 @@ int msm_dsi_host_register(struct mipi_dsi_host
>> *host, bool check_defer)
>> node = of_get_child_by_name(msm_host->pdev->dev.of_node,
>> "panel");
>> if (node) {
>> + of_node_put(node);
>> +
>
> Atleast from the current state of code, It looks like the driver is
> going to refer to the node of_node_put?, So I think this is not the
> right place to have of_node_put.
That's right. I made the same mistake in the later patches too. I'll fix
these.
Thanks,
Archit
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists