linux-kernel - Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1775494.ZyQRebyBWF@wuerfel>
Date:	Tue, 23 Jun 2015 12:13:47 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Gaston Gonzalez <gascoar@...il.com>
Cc:	gregkh@...uxfoundation.org, paul.gortmaker@...driver.com,
	dilekuzulmez@...il.com, gdonald@...il.com,
	cristina.opriceana@...il.com, hamohammed.sa@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]  staging: rtl8192u: ieee80211_rx:  Fix incorrect type in assignments

On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote:
>                 /* WMM spec P.11: The minimum value for AIFSN shall be 2 */
>                 qos_param->aifs[aci] = (qos_param->aifs[aci] < 2) ? 2:qos_param->aifs[aci];
>  
> -               qos_param->cw_min[aci] = ac_params->ecw_min_max & 0x0F;
> +               qos_param->cw_min[aci] =
> +                       cpu_to_le16(ac_params->ecw_min_max & 0x0F);
>  
> -               qos_param->cw_max[aci] = (ac_params->ecw_min_max & 0xF0) >> 4;
> +               qos_param->cw_max[aci] =
> +                       cpu_to_le16((ac_params->ecw_min_max & 0xF0) >> 4);
>  
>                 qos_param->flag[aci] =
>                     (ac_params->aci_aifsn & 0x10) ? 0x01 : 0x00;
> -               qos_param->tx_op_limit[aci] = le16_to_cpu(ac_params->tx_op_limit);
> +               qos_param->tx_op_limit[aci] = ac_params->tx_op_limit;
>         }
>         return 0;

This certainly needs a more thorough description of how you determined that
the byte swaps that you add are in fact required. Did you test it on
a big-endian machine?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/