linux-kernel - Re: [PATCH] i2c: designware: use enable on resume instead initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150624112723.GE827@lahna.fi.intel.com>
Date:	Wed, 24 Jun 2015 14:27:23 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	christian.ruppert@...tech.com
Cc:	Lucas De Marchi <lucas.de.marchi@...il.com>,
	Christian Ruppert <christian.ruppert@...lis.com>,
	Fabio Mello <fabio.mello@...el.com>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	linux-i2c@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
	Lucas De Marchi <lucas.demarchi@...el.com>,
	Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH] i2c: designware: use enable on resume instead
 initialization

On Wed, Jun 24, 2015 at 09:36:43AM +0200, christian.ruppert@...tech.com wrote:
> Dear Lucas,
> 
> Lucas De Marchi <lucas.de.marchi@...il.com> wrote on 23.06.2015 19:02:03:
> > On Tue, Jun 23, 2015 at 1:45 PM,  <christian.ruppert@...tech.com> wrote:
> > > Hello,
> > >
> > > Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16:
> > [...]
> > > The result is not very encouraging: Out of five (identical) designware 
> i2c
> > > controllers we have on my test SOC, the first one initialises properly 
> but
> > > the second one gets stuck in the famous irq loop right away when the
> > > module is enabled in i2c_dw_init. The system never gets around to try
> > 
> > Are you using the pci or platform driver?  I noticed yesterday the pci
> > version is failing here with a NULL pointer dereference.
> 
> The test was performed with the platform driver (instantiated through 
> device tree).
> I just re-checked and the ultimate problem which hangs/kills the system in 
> my case is the IRQ loop.
> I haven't observed any NULL pointer dereferences on the road.

Thanks Christian for testing.

Since the patch causes problems on your hardware, I don't think it is
good idea to merge it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/